Skip to content

Set SERVER_PORT appropriately #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set SERVER_PORT appropriately #1628

wants to merge 1 commit into from

Conversation

ac000
Copy link
Member

@ac000 ac000 commented Jul 4, 2025 

The Perl, PHP, Python and Ruby language modules all hard code
SERVER_PORT to "80".

Adjust them to bring them in line with the wasm language module which
uses r->local_port (I.e. the port unit accepted the connection on).

Closes: https://github.com/nginx/unit/issues/761
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>

@ac000
Set SERVER_PORT appropriately
d0dafc2 
The Perl, PHP, Python and Ruby language modules all hard code
SERVER_PORT to "80".

Adjust them to bring them in line with the wasm language module which
uses r->local_port (I.e. the port unit accepted the connection on).

Closes: nginx#761
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
@ac000 ac000 marked this pull request as ready for review July 4, 2025 15:57
@ac000 ac000 requested review from hongzhidao July 4, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongzhidao hongzhidao Awaiting requested review from hongzhidao

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ac000